osmo-msc[master]: libmsc/gsm_04_80.c: drop unused 'in_msg' argument

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 9 16:07:01 UTC 2018


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/7674/1/include/osmocom/msc/gsm_04_80.h
File include/osmocom/msc/gsm_04_80.h:

Line 10: 	const char* response_text, const struct ss_request *req);
(I would rather keep the same indenting style as below, and for added bonus just modify the single line so the patch touches as few lines as possible)


https://gerrit.osmocom.org/#/c/7674/1/src/libmsc/ussd.c
File src/libmsc/ussd.c:

Line 44: 	const struct ss_request *req)
(again, indent: rather stay with the style of surrounding code. Most editors do that indenting automatically)


-- 
To view, visit https://gerrit.osmocom.org/7674
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list