[PATCH] osmo-bsc[master]: fix initialization of acc ramping

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Apr 9 15:08:34 UTC 2018


Review at  https://gerrit.osmocom.org/7691

fix initialization of acc ramping

Remove a redundant call to acc_ramp_init() during bootstrap_bts().
ACC ramping state is already initialized during VTY config parsing,
and bootstrap_bts() accidentally disabled ACC ramping again even
if it was enabled in the configuration.

This bug was introduced in last-minute refactoring during
review of https://gerrit.osmocom.org/#/c/6324/ when the
acc_ramping_enabled flag was moved from struct gsm_bts to
the acc_ramp structure itself.

Change-Id: Ib7d99c9d3d5d424e21bb7710f719c42f9aef3e95
Related: OS#2591
---
M src/libbsc/bsc_init.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/7691/1

diff --git a/src/libbsc/bsc_init.c b/src/libbsc/bsc_init.c
index ba8b8e6..366b01f 100644
--- a/src/libbsc/bsc_init.c
+++ b/src/libbsc/bsc_init.c
@@ -539,7 +539,7 @@
 
 	bts->chan_load_samples_idx = 0;
 
-	acc_ramp_init(&bts->acc_ramp, false, bts);
+	/* ACC ramping is initialized from vty/config */
 
 	/* Initialize the BTS state */
 	gsm_bts_mo_reset(bts);

-- 
To view, visit https://gerrit.osmocom.org/7691
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7d99c9d3d5d424e21bb7710f719c42f9aef3e95
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>



More information about the gerrit-log mailing list