[MERGED] osmo-ci[master]: osmo-clean-workspace.sh: cosmetic: no need to clean -e deps

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 9 12:52:08 UTC 2018


Neels Hofmeyr has submitted this change and it was merged.

Change subject: osmo-clean-workspace.sh: cosmetic: no need to clean -e deps
......................................................................


osmo-clean-workspace.sh: cosmetic: no need to clean -e deps

git clean always excludes git clone subdirs; furthermore, even if I supply a
dir as -e, the contents of that dir still get cleaned out. So it is useless to
pass -e on the commandline. Drop it.

Change-Id: I2b59cc9c9adf88a2663469b22cfeffbd66b5bf2e
---
M scripts/osmo-clean-workspace.sh
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/scripts/osmo-clean-workspace.sh b/scripts/osmo-clean-workspace.sh
index 4b77066..fcbfea8 100755
--- a/scripts/osmo-clean-workspace.sh
+++ b/scripts/osmo-clean-workspace.sh
@@ -25,7 +25,8 @@
 git checkout -f HEAD
 
 # wipe all unversioned leftovers, except deps gits.
-git clean -dxf -e "$deps" -e "layer1-headers"
+# Git automatically excludes subdirs that are git clones.
+git clean -dxf
 
 # leave the deps checkouts around, to not clone entire git history every time,
 # but clean each git of build artifacts.

-- 
To view, visit https://gerrit.osmocom.org/7688
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b59cc9c9adf88a2663469b22cfeffbd66b5bf2e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list