libosmo-netif[master]: stream.c: osmo_stream_cli_open2: Remove wrong assumption in ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 5 19:56:20 UTC 2018


Patch Set 1: Code-Review+1

I'm not entirely sure if this is the right approach.  Aren't there fatal/permanent causes in which connect() can fail and there's no point in trying to reconnect?  I mean, if the connection is refused or times out, reconnecting is fine.  But what if the local port the user has specified is used by some other program? Maybe I'm worrying too much... So this is not a veto, just a hunch that this might be a bit too "agressive"?

-- 
To view, visit https://gerrit.osmocom.org/7650
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25b33f4cdc496ae31ff240d445b9b2805091845c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list