This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7633 fix 'make -C subdir': use $(shell pwd) instead of $PWD $PWD does not get updated when make steps into a subdir. The pwd output does. So obtain the current dir from shell pwd instead of $PWD. So far, when doing 'make -C osmo-foo-maser', the image's name would be derived from the root dir's basename and all images were tagged as 'docker-playground'. With this fix, 'make -C' from anywhere still tags with the proper name. Change-Id: I1dd0fd1ad89fdee18fdbea851ccc831ad60aeccf --- M make/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/33/7633/1 diff --git a/make/Makefile b/make/Makefile index 14d4c52..45ecb5a 100644 --- a/make/Makefile +++ b/make/Makefile @@ -15,7 +15,7 @@ # REGISTRY_HOST=docker.io USERNAME=$(USER) -NAME=$(shell basename $(PWD)) +NAME=$(shell basename $(shell pwd)) RELEASE_SUPPORT := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))/.make-release-support IMAGE=$(REGISTRY_HOST)/$(USERNAME)/$(NAME) -- To view, visit https://gerrit.osmocom.org/7633 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1dd0fd1ad89fdee18fdbea851ccc831ad60aeccf Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>