[MERGED] osmo-bsc[master]: cosmetic: Add fixme note for OS#3112

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 2 19:33:11 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: cosmetic: Add fixme note for OS#3112
......................................................................


cosmetic: Add fixme note for OS#3112

Change-Id: I0c3ffb567aff08014f8fb96928077afb8c2f229c
---
M src/osmo-bsc/osmo_bsc_msc.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c
index 2178d1d..e9309ea 100644
--- a/src/osmo-bsc/osmo_bsc_msc.c
+++ b/src/osmo-bsc/osmo_bsc_msc.c
@@ -48,6 +48,11 @@
 		return -1;
 	}
 
+	/* FIXME: This is a leftover from the old architecture that used
+	 * sccp-lite with osmocom specific authentication. Since we now
+	 * changed to AoIP the connected status and the authentication
+	 * status is managed differently. However osmo_bsc_filter.c still
+	 * needs the flags to be set to one. See also: OS#3112 */
 	data->msc_con->is_connected = 1;
 	data->msc_con->is_authenticated = 1;
 

-- 
To view, visit https://gerrit.osmocom.org/7507
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c3ffb567aff08014f8fb96928077afb8c2f229c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list