meta-telephony[201705]: osmo-sgsn: Introduce recipe

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Sep 29 12:12:56 UTC 2017


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/4095/1/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
File recipes-osmocom/osmo-sgsn/osmo-sgsn.inc:

Line 25: PACKAGES =+ "osmo-gbproxy-doc osmo-gtphub-doc osmo-gbproxy osmo-gtphub"
> there isn't a gtphub service file further above. I guess it doesn't really 
There's no gtphub service being installed because basically there no such service file in osmo-sgsn repository, it is missing there.

As we don't really require it for now, it's fine to have the package without a service file. In any case, we are not installing it in our images, but it is still nice to have the package available in case somebody wants to install it from feeds and run it.

Take into account thiese "install" cmds are not installing into the image, but into a tmp directory which is used to build the packages. Then in the image recipe you specify which packages it should contain and it simply installs the packages.


Line 38: 		"
> (I'm confused, don't we need FILES_osmo-sgsn as well?)
FILES_${PN} (FILES_osmo-sgsn in this case) is handled/populated by default by some OE class (package.bbclass?), no need to explicitly state it. And it's usually better to leave OE do all the magic.

Also, FILES for each package are taken based on order in PACKAGES variable. That's why I'm prepending ("=+" in bitbake syntax), because otherwise everything would end up in FILES_osmo-sgsn


-- 
To view, visit https://gerrit.osmocom.org/4095
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e35660598bfd87917728c521c1fba827e98d68
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list