meta-telephony[201705]: Update osmocom versions to point to current master

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Sep 29 11:08:45 UTC 2017


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/4087/1/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
File recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb:

Line 7: 
> erm, wasn't the EXTRA_OECONF_remove just added in the preceding patch? Does
Hi Neels, indeed this was added and removed like you say, but it has an explanation:

These first commits basically come from current laforge/nightly, in which we keep the osmocom recipes with SRCREV ="AUTOINC", which basically thakes latest master every time the recipe is run. In there, we spot new build issues and we fix them in there. To apply new changes, I need newer revisions than the ones from current stable 201705, and so I pull all the commits pushed into laforge/nightly.
I think it's fair to leave addition then removal of this lines in the commits to leave it as history to understand better why is this needed or not. Otherwise you end up with lines doing strange things in recipes and you are never sure why is that being done or what's the purpose, or if they can already be removed.

Somebody spent hours trying to fix stuff and applying a better fix, so it's better to just keep the history.


https://gerrit.osmocom.org/#/c/4087/1/recipes-osmocom/libosmocore/libosmocore_git.bb
File recipes-osmocom/libosmocore/libosmocore_git.bb:

Line 7: PR = "r1"
> when the hash changes, should PR go to 0?
Agree


https://gerrit.osmocom.org/#/c/4087/1/recipes-osmocom/openggsn/openggsn_git.bb
File recipes-osmocom/openggsn/openggsn_git.bb:

Line 1: DESCRITOPN = "OpenGGSN a Free Software GGSN"
> DECROPITION ... and why bother to modify openggsn when we have osmo-ggsn?
We still don't have osmo-ggsn here, this is the first commit in the patchset, and makes later patches more incremental.


-- 
To view, visit https://gerrit.osmocom.org/4087
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If36b86a6a542af7381d9a07da51a330f2e44a96f
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list