This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(4 comments)
https://gerrit.osmocom.org/#/c/4100/1/recipes-osmocom/openbsc/openbsc.inc
File recipes-osmocom/openbsc/openbsc.inc:
Line 10: file://osmo-bsc_mgcp.init \
> shouln't osmo-bsc_mgcp come from osmo-mgw.git now?
Indeed, this reference (+file) needs to be removed. Thanks for pointing out.
Line 12: file://osmo-sgsn.init \
> shouldn't osmo-sgsn come from osmo-sgsn.git now?
Indeed, this reference (+file) needs to be removed. Thanks for pointing out.
Line 32:
> ...ah, they are removed here, maybe also on top
Agree, when I removed this lines I didn't pay attention to see that files come from meta-telephony and not from openbsc.git, so they need to be removed in the meta-telephony repo too.
Line 40: install -d ${D}${systemd_system_unitdir}/
> stripping a path element? didn't read about that in the commit log. Is it c
Yes, this change is correct, and the old ${systemd_unitdir} is incorrect by nature because system and user systemd units can have a different prefix (before the systemd/ dir). systemd_unitdir would have been marked as deprecated if there was a way to do so. I know for sure, I was the one adding this variable in OE a few years ago :)
If you are interested about the different paths, you can look at https://github.com/openembedded/openembedded-core/blob/master/meta/conf/bitbake.conf
--
To view, visit https://gerrit.osmocom.org/4100
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd029cbd36417ee980bff51b4112705be16175d3
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes