This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4073 to look at the new patch set (#2). Use extended logging for PDP contexts Log additional details (IMSI, NSAPI etc) on PDP context creation/deletion by using appropriate LOGP() wrappers. Change-Id: I91a126952ae75ae9ba1f42aac4d26413384bba5d Related: SYS#3610 --- M configure.ac M src/gprs/sgsn_libgtp.c 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/73/4073/2 diff --git a/configure.ac b/configure.ac index 532b977..3742594 100644 --- a/configure.ac +++ b/configure.ac @@ -62,7 +62,7 @@ found_libgtp=yes -PKG_CHECK_MODULES(LIBGTP, libgtp >= 0.92, , found_libgtp=no) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.0.0, , found_libgtp=no) AM_CONDITIONAL(HAVE_LIBGTP, test "$found_libgtp" = yes) AC_SUBST(found_libgtp) diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c index 9a00266..9b8fe16 100644 --- a/src/gprs/sgsn_libgtp.c +++ b/src/gprs/sgsn_libgtp.c @@ -145,7 +145,6 @@ const uint8_t *qos; int rc; - LOGP(DGPRS, LOGL_ERROR, "Create PDP Context\n"); pctx = sgsn_pdp_ctx_alloc(mmctx, nsapi); if (!pctx) { LOGP(DGPRS, LOGL_ERROR, "Couldn't allocate PDP Ctx\n"); @@ -174,6 +173,7 @@ pdp->selmode = 0xFC | 0x00; /* IMSI, TEID/TEIC, FLLU/FLLC, TID, NSAPI set in pdp_newpdp */ + LOGPDPCTXP(LOGL_NOTICE, pctx, "Create PDP Context\n"); /* Put the MSISDN in case we have it */ if (mmctx->subscr && mmctx->subscr->sgsn_data->msisdn_len) { @@ -635,7 +635,8 @@ /* Called whenever a PDP context is deleted for any reason */ static int cb_delete_context(struct pdp_t *pdp) { - LOGP(DGPRS, LOGL_INFO, "PDP Context was deleted\n"); + LOGPDPX(DGPRS, LOGL_INFO, pdp, "Context was deleted\n") ; + return 0; } -- To view, visit https://gerrit.osmocom.org/4073 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91a126952ae75ae9ba1f42aac4d26413384bba5d Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder