[PATCH] osmo-bts[master]: Replace dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Sep 27 12:05:27 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/4057

to look at the new patch set (#2).

Replace dead code

* remove leftover from copy-paste of corresponding OpenBSC code
* print OML link state
* print paging load

Change-Id: Ia5e3dc10efe2b5ab212cab1518a10d36b20b8bb2
---
M src/common/vty.c
1 file changed, 5 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/4057/2

diff --git a/src/common/vty.c b/src/common/vty.c
index de9b23f..ef56705 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -762,24 +762,11 @@
 		VTY_NEWLINE);
 	vty_out(vty, "  CBCH backlog queue length: %u%s",
 		llist_length(&btsb->smscb_state.queue), VTY_NEWLINE);
-#if 0
-	vty_out(vty, "  Paging: %u pending requests, %u free slots%s",
-		paging_pending_requests_nr(bts),
-		bts->paging.available_slots, VTY_NEWLINE);
-	if (is_ipaccess_bts(bts)) {
-		vty_out(vty, "  OML Link state: %s.%s",
-			bts->oml_link ? "connected" : "disconnected", VTY_NEWLINE);
-	} else {
-		vty_out(vty, "  E1 Signalling Link:%s", VTY_NEWLINE);
-		e1isl_dump_vty(vty, bts->oml_link);
-	}
-
-	/* FIXME: chan_desc */
-	memset(&pl, 0, sizeof(pl));
-	bts_chan_load(&pl, bts);
-	vty_out(vty, "  Current Channel Load:%s", VTY_NEWLINE);
-	dump_pchan_load_vty(vty, "    ", &pl);
-#endif
+	vty_out(vty, "  Paging: queue length %d, buffer space %d%s",
+		paging_queue_length(btsb->paging_state), paging_buffer_space(btsb->paging_state),
+		VTY_NEWLINE);
+	vty_out(vty, "  OML Link state: %s.%s",
+		bts->oml_link ? "connected" : "disconnected", VTY_NEWLINE);
 }
 
 

-- 
To view, visit https://gerrit.osmocom.org/4057
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5e3dc10efe2b5ab212cab1518a10d36b20b8bb2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list