This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/4058/1/src/common/vty.c
File src/common/vty.c:
Line 770: if (pinst) {
> Can pinst be null? ie can a trx have no phy instance?
AFAIK no, but trx_phy_instance() can return NULL so it's better to check for it.
Line 771: vty_out(vty, " phy %d %s", pinst->num, pinst->version);
> Is version a string? sounds like pinst->num should be an unsigned integer.
Yes, version is a string (which could be 0-length though). I agree that num should be unsigned but it's "int" in hte header so it's better to print it as such.
--
To view, visit https://gerrit.osmocom.org/4058
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabcc862566b40a9314f3e1d17fda61d8ab24a3cd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes