This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Review at https://gerrit.osmocom.org/4062
comment: ctrl: explain why status-ps is a SET cmd
Change-Id: I1ccf6affaf3c5f2096fd3eb36454b18c3670a1b0
---
M src/ctrl.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/62/4062/1
diff --git a/src/ctrl.c b/src/ctrl.c
index 81de961..40c1e53 100644
--- a/src/ctrl.c
+++ b/src/ctrl.c
@@ -74,6 +74,10 @@
return handle_cmd_ps(data, cmd, false);
}
+/* NOTE: Even though status-ps is actually a read-only operation, it is
+ * implemented as a 'SET' command, so that we are able to pass the IMSI as
+ * argument. 'GET' commands cannot be passed arguments besides the variable
+ * name. */
CTRL_CMD_DEFINE_WO_NOVRF(status_ps, "status-ps");
static int set_status_ps(struct ctrl_cmd *cmd, void *data)
{
--
To view, visit https://gerrit.osmocom.org/4062
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ccf6affaf3c5f2096fd3eb36454b18c3670a1b0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>