This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 1: (5 comments) Also, example output of 'sh talloc-context ..' in commit message would be nice. https://gerrit.osmocom.org/#/c/4018/1/src/vty/talloc_ctx_vty.c File src/vty/talloc_ctx_vty.c: Line 48: I think it's big enough to warrant doxygen header with explanation of what it does and what's the meaning of parameters. Line 50: int max_depth, int is_ref, void *data) If it's 'int' than it means that it could be negative. Please either explain when this is the case or use unsigned type. Line 63: if (p->filter == WALK_FILTER_REGEXP) { So you explicitly check for 2 possible enum values and implicitly for 3rd one. I think switch() would be easier to read because all possible values are checked explicitly. Line 139: params = talloc_zero(tall_vty_ctx, struct walk_cb_params); Will this allocation be included in the report too? Line 229: talloc_free(params); The params are always alloced/freed in the same function. Do we have to use dynamic allocation? What would be disadvantage of having 'params' as local variable which address is passed down to talloc_ctx_walk()? -- To view, visit https://gerrit.osmocom.org/4018 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43fc42880b22294d83c565ae600ac65e4f38b30d Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes