This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 4: (6 comments) https://gerrit.osmocom.org/#/c/4003/4//COMMIT_MSG Commit Message: Line 18: *) use a list to manage rtp connections. Here would be good to say where these structs are embedded into the endpoint and how they are freed. E.g. which lifetime it has. Line 29: anymore. This patch removes the related code. > IIUC all transcoding has been removed, but I can still find transcoding rel Why would you drop the internal/synchronous transcoding? Line 35: the fixed CONN_BTS and CONN_NET constants. Dynamic is code but keep in mind that BTS might be in network/vlan and external network in another? You might want to bind to different interfaces? Line 68: - Add 'I: 1' parameters. did you check the nat code if it always includes the I. It was kind of an anti feature. Line 74: returned. Why 40ms? https://gerrit.osmocom.org/#/c/4003/4/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: Line 225: conn = llist_last_entry(conns, struct mgcp_conn, entry); What if the list is empty? -- To view, visit https://gerrit.osmocom.org/4003 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie008599136c7ed8a0dfbb0cf803188975a499fc5 Gerrit-PatchSet: 4 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-HasComments: Yes