libosmocore[master]: vty: use internal node id for xml ids

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Sep 20 15:44:11 UTC 2017


Patch Set 2:

> Okay makes sense. But is cnode->node unique it seems to be solely
 > external defined but then it might be more stable?

The node ID is what we use to enter VTY nodes, and it is required to be unique within a given main() program. We do this:

    enum bsc_vty_node {
            GSMNET_NODE = _LAST_OSMOVTY_NODE + 1,
            BTS_NODE,
            TRX_NODE,
            ...

so these numbers should be unique enough.

Anyway I would favor using the node name as in the other patch, because it makes writing osmo-gsm-manuals vty references much easier for humans: instead of <node id='32'> we can do <node id='config-smpp'>

-- 
To view, visit https://gerrit.osmocom.org/3978
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib07fb9d9106e19f5be6539493e82b5d5991f8bc2
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list