[MERGED] osmo-msc[master]: ctrl: remove unimplemented cmds subscriber-{modify, delete}

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Sep 19 01:09:04 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: ctrl: remove unimplemented cmds subscriber-{modify,delete}
......................................................................


ctrl: remove unimplemented cmds subscriber-{modify,delete}

Change-Id: I754de5d08c053fea5f1ca2673b0ac4d26a85778a
---
M src/libmsc/ctrl_commands.c
1 file changed, 0 insertions(+), 22 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/ctrl_commands.c b/src/libmsc/ctrl_commands.c
index 4767ddd..c6236ed 100644
--- a/src/libmsc/ctrl_commands.c
+++ b/src/libmsc/ctrl_commands.c
@@ -31,26 +31,6 @@
 
 static struct gsm_network *msc_ctrl_net = NULL;
 
-static int verify_subscriber_modify(struct ctrl_cmd *cmd, const char *value, void *d)
-{
-	return 0;
-}
-
-static int set_subscriber_modify(struct ctrl_cmd *cmd, void *data)
-{
-	cmd->reply = "Command moved to osmo-hlr, no longer available here";
-	return CTRL_CMD_ERROR;
-}
-
-CTRL_CMD_DEFINE_WO(subscriber_modify, "subscriber-modify-v1");
-
-static int set_subscriber_delete(struct ctrl_cmd *cmd, void *data)
-{
-	cmd->reply = "Command moved to osmo-hlr, no longer available here";
-	return CTRL_CMD_ERROR;
-}
-CTRL_CMD_DEFINE_WO_NOVRF(subscriber_delete, "subscriber-delete-v1");
-
 static int get_subscriber_list(struct ctrl_cmd *cmd, void *d)
 {
 	struct vlr_subscr *vsub;
@@ -84,8 +64,6 @@
 	int rc = 0;
 	msc_ctrl_net = net;
 
-	rc |= ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_subscriber_modify);
-	rc |= ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_subscriber_delete);
 	rc |= ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_subscriber_list);
 	return rc;
 }

-- 
To view, visit https://gerrit.osmocom.org/3982
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I754de5d08c053fea5f1ca2673b0ac4d26a85778a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list