osmo-pcu[master]: Simplify TS alloc: improve readability

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Sep 18 16:08:41 UTC 2017


Patch Set 15:

(5 comments)

I have mixed feelings about the change. It seems churn and I don't see the development path of this branch yet.

https://gerrit.osmocom.org/#/c/3760/15/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:

Line 706
How does this debugging code hurt you? As someone that needed to understand it. Wasn't it helpful to follow Jacob's line of thinking?


Line 251: 					LOGP(DRLCMAC, LOGL_DEBUG, "- Skipping TS %d, because no TFI available\n", ts);
Old and new code doesn't fit on my macbook air 13" screen. So I don't think it is a general improvement. I see the merit of having the log in a single line but this makes me scroll on review.


Line 382: 	if (trx) {
What is the reason to move this here?


Line 799: 	ul_slots = ms->reserved_ul_slots();
So this is to avoid the reassignment?


Line 806: 		LOGP(DRLCMAC, LOGL_NOTICE, "- Failed to allocate a TFI\n");
This is the part of the change I don't like. You remove the TRX check and now we will get "Failed to allocate a TFI" when we haven't even tried to allocate one as the precondition failed?


-- 
To view, visit https://gerrit.osmocom.org/3760
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02da2b8ba8c9c8815dae0e39e1fed277ca0df171
Gerrit-PatchSet: 15
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list