osmo-gsm-tester[master]: suite: Replicate resources based on times attr before callin...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Sep 14 02:13:15 UTC 2017


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/3907/3/selftest/suite_test/test_suite/suite.conf
File selftest/suite_test/test_suite/suite.conf:

Line 6:   - times: 2
> It really doesn't matter if I add more attributes or not for the test case 
it would serve to see which one of them got duplicated :)
...no strong opinion though, it just sprung my eye and I wondered if it was intended.


https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 61:         'bts[].trx_list[].nominal_power': schema.INT,
> I wanted to use an attribute from trx_list[] to test different more complex
hw_addr and net_device will, IIRC, be useful for octphy.

What are we using the nominal power for?
I wouldn't add values in the production code merely to serve the unit tests... If we need nominal power, let's add it in a separate patch.


-- 
To view, visit https://gerrit.osmocom.org/3907
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25eb639c7e3cf3b4c67a205422808bffbdd791e6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list