openbsc[master]: libmsc: annotate esme route in the sms object from deliver_t...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pablo Neira Ayuso gerrit-no-reply at lists.osmocom.org
Mon Sep 11 16:11:26 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/3900/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:

Line 718: 	sms->smpp.esme = esme;
> check that we're not overwriting sms->smpp.esme if it is already set? (i.e 
Please, if you carefully review the codepath you will notice that is always unset...

However, you vote this with -1 and this is blocking a real fix, something that Keith confirms that is solving a real problem there.

I don't want to add this superfluous check, it's better to agree on semantics, not just add a branch there because maybe someone else make a sloppy use of this in the future...

Stop forcing people to do overly defensive programming, just because you are scared.

Or develop your real concerns, instead of nacking work from others with poor arguments.

Thank you.


-- 
To view, visit https://gerrit.osmocom.org/3900
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8a8fd9bbb0d3b6aff7931e4bacbea99d000e484
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list