osmo-gsm-tester[master]: modem: Fix race condition when connect() is called more than...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Sep 11 13:24:14 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3901/1/suites/aoip_encryption/register_a5_0_authreq.py
File suites/aoip_encryption/register_a5_0_authreq.py:

Line 34: sleep(40) # TODO: read pcap or CTRL interface and look for Rejected? (gsm_a.dtap.msg_mm_type == 0x04)
> in general, if at all possible, we should avoid arbitrary sleeps, we can ne
At some point I'd like having some common interface by which you can request a pcap file from the object, and then be able to do some checks on it through a class, which would call tshark or some python pcap module. In this case, we could check for instance that there were not Location Accept, and that there was at least one Location reject.

I've worked with testing frameworks which did tests then checked everything on recorded pcap files and it's really powerful and useful.

We could then use this kind of greps over pcap files together with test.wait() to poll until some event is done.


-- 
To view, visit https://gerrit.osmocom.org/3901
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4bb1c6b72c23cd860c33bee7851bca3d0ac0e1b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list