This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/3828/4/src/libbsc/abis_rsl.c File src/libbsc/abis_rsl.c: Line 1228: int rsl_lchan_set_state_with_log(struct gsm_lchan *lchan, uint8_t state, const char *file, unsigned line) why are we changing from an 'int' to an uint8_t here? The gsm_lchan.state menmber is of type "enum gsm_lchan_state", so "int" is actually closer to the truth than uint8_t. And if you want to make a "proper" change, then they argument type should be of "enum gsm_lchan_state", no? -- To view, visit https://gerrit.osmocom.org/3828 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21789f8021290965b61a54a2b23177ccbbfe8321 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes