[PATCH] osmo-pcu[master]: Return if failed to determine current UL CS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Sep 8 10:35:46 UTC 2017


Review at  https://gerrit.osmocom.org/3893

Return if failed to determine current UL CS

This only possible if neither GPRS or EGPRS mode is set but since code
below relies on non-zero value it's better to be paranoid nevertheless.

Change-Id: I8f62627b7b7b89dfa1b0d1a7e71b95b2c40fdffa
Fixes: CID70466
---
M src/gprs_ms.cpp
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/93/3893/1

diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index 66312fa..e9e16d0 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -630,6 +630,11 @@
 		return;
 	}
 
+	if (!current_cs_num) {
+		LOGP(DRLCMACMEAS, LOGL_ERROR, "Current UL CS converts to 0?!\n");
+		return;
+	}
+
 	if (!m_current_cs_ul)
 		return;
 

-- 
To view, visit https://gerrit.osmocom.org/3893
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f62627b7b7b89dfa1b0d1a7e71b95b2c40fdffa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list