[PATCH] openbsc[master]: libmsc: Either route report to ESME or send it, not both

[Keith Whyte]

Review at  https://gerrit.osmocom.org/3885

libmsc: Either route report to ESME or send it, not both

Logic in sms_status_report():  We cannot check gsms->receiver
as an indication that sms_route_mt_sms failed to find a route.
gsms is the original message for which we are sending a report,
so it already has a receiver.

Change-Id: I8e86a34f5d3087c9c25479192d9a690922113da2
---
M openbsc/src/libmsc/gsm_04_11.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/85/3885/1

diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c
index ddef444..86cdb8e 100644
--- a/openbsc/src/libmsc/gsm_04_11.c
+++ b/openbsc/src/libmsc/gsm_04_11.c
@@ -690,6 +690,13 @@
 		     "Failed to send status report! err=%d\n", rc);
 	}
 
+	if (rc == 0) {
+		LOGP(DLSMS, LOGL_INFO,
+		    "Status report for %s was routed to ESME\n", gsms->receiver->extension);
+		sms_free(sms_report);
+		return;
+	}
+
 	/* No route via SMPP, send the GSM 03.40 status-report now. */
 	if (gsms->receiver)
 		gsm340_rx_sms_submit(sms_report);

-- 
To view, visit https://gerrit.osmocom.org/3885
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e86a34f5d3087c9c25479192d9a690922113da2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>