libosmocore[master]: VTY: implicit node exit by de-indenting, not parent lookup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Sep 7 11:48:40 UTC 2017


Patch Set 1:

Thanks for looking into this.  I think it might be difficult to insist on one space idnent per level. It would be much mor user friendly if there was a notion of 'parent node depth', i.e. you can use any number of additional spaces to indent a new depth level, and as soon as you go back beyond that depthy level we go to the parent.  Not sure how comple that would be to implement?

Also, if we now have a notion of the "depth", could this somehow be used to automatically generate the required spaces in front of a string when saving the file (config_write_...())?  So far we manually have to print those spaces which is a bit ugly (and doesn't permit a node to appear at different parent nodes / depths).

-- 
To view, visit https://gerrit.osmocom.org/3880
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24cbb3f6de111f2d31110c3c484c066f1153aac9
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list