osmo-gsm-tester[master]: modem: log property changes from Modem interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Sep 6 15:00:09 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

(I'd give +2 and let you decide, but want to make sure you notice there are comments.)

https://gerrit.osmocom.org/#/c/3834/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:

Line 228:             self.dbg('%r.PropertyChanged() -> %s=%s' % (I_MODEM, name, value))
I'd prefer to drop all that is anyway constant. i.e. only log '%s=%s', and maybe rather '%s=%r'.

Or use the dict style

  self.dbg(name=value)

If you do want to indicate that a prop was received, rather less long?

  self.dbg('rx', name=value)


-- 
To view, visit https://gerrit.osmocom.org/3834
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If215c7d63ce1b86314ed25f8e76413b15676b7f5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list