osmo-bts[master]: OML: print actual type of report sent to BSC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Sep 6 14:14:02 UTC 2017


Patch Set 1:

> I've tried to stick to convention of the code around: function name
 > reflects the message type/format from spec, log reflects the
 > content - what we use this message for.

Current patch e.g.

  Sending Unknown message to BSC: ...

vs something like

  Sending FAILURE ("Unknown message") to BSC: ...

The former can be confusing to the uninformed reader (Why are we sending an unknown message?) -- rather clarify a failure message with a cause reporting the error of receiving and unknown message...?

-- 
To view, visit https://gerrit.osmocom.org/3829
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9413ecf57eaa6fc661f1a57ccdaa2f04c50ea43b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list