[MERGED] libosmocore[master]: cosmetic: clarify language in vty read error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Sep 5 10:44:22 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: cosmetic: clarify language in vty read error
......................................................................


cosmetic: clarify language in vty read error

This is very minor but it annoys every time I see it.
The text: "Error occurred during reading below line:"
is not a complete sentence. The default understanding
in english having left out the article implies
that the error occured reading below [the] specified line, not
that the error occured reading [the] specified line.

That is to say, The message implied that the printed line
was the last successfully parsed line.

Change-Id: Ib4dd135feb9609b14983db5dac321a70267d8f30
---
M src/vty/vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/vty/vty.c b/src/vty/vty.c
index 644d4ed..113a781 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -1481,7 +1481,7 @@
 			fprintf(stderr, "There is no such command.\n");
 			break;
 		}
-		fprintf(stderr, "Error occurred during reading below "
+		fprintf(stderr, "Error occurred during reading the below "
 			"line:\n%s\n", vty->buf);
 		vty_close(vty);
 		return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/3805
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4dd135feb9609b14983db5dac321a70267d8f30
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list