osmo-gsm-tester[master]: Add features attribute to modems

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Sep 4 15:02:28 UTC 2017


Patch Set 1:

(2 comments)

>From my point of view, we can merge this one.

https://gerrit.osmocom.org/#/c/3763/1/example/resources.conf
File example/resources.conf:

Line 63:   features: ['sms']
> again the '- item' list format consideration, if you agree
I'd like to keep this format, it's more compact and handy when I'm looking through the resources.conf. It also took me a while to understand how arrays are formatted with the other format, I find this one a lot more natural.

In case we move to a new parsing engine (ie. never), then we can easily move a few configuration to use a different format. Meanwhile (eternity), let's enjoy it.


Line 79:   features: []
> (let's just omit the property if it is empty)
If you don't mind I'll keep this one like this because of course it has some features but I didn't get to test them yet, so I need to fill them at some point, hopefully soon. This way to I can remember more easily to do it.


-- 
To view, visit https://gerrit.osmocom.org/3763
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1634049f01859ae0310174892a96e204bb670bc1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list