osmo-gsm-tester[master]: resource: Fix list comparison in item_matches

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Sep 4 09:48:45 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3721/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 449:                 return False
> It is potentially dangerous to change this logic and I want to be sure I un
I'll provide a test for this. I think I stumbled onto it when trying to use more than one scenario together, ie: -s encryption:cipher_a51+cipher_a52.

AFAIR there were several things not correct in this code before my change:
- It is expected that item and wanted_item to be the of the same type (because they follow same syntax). Thus in this case of are type list. AFAIR I checked and using this syntax doesn't work correctly to check if a list is a sublist/subset of another list.
- I think here you want to check the opposite, that is: if all wanted items are a subset of the item capabilitites. For instance if a modem supports 3 ciphers, and you want a scenario which supports 2, then len(wanted_item)==2 and len(item)==3, and you want to check that wnated_item is a subset of item.


-- 
To view, visit https://gerrit.osmocom.org/3721
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27b372aa5906feac2843f24f5cdd0d9578d44b4d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list