[MERGED] libosmo-sccp[master]: sccp_sap.h: Fix SSN for BSSAP and BSSAP-LE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Sep 3 21:12:42 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: sccp_sap.h: Fix SSN for BSSAP and BSSAP-LE
......................................................................


sccp_sap.h: Fix SSN for BSSAP and BSSAP-LE

* BSSAP is 254 on both MSC and BSC side: Add missing define
* BSSAP-LE (LCS Extension) has 250/251, adjust name to add -LE suffix

Change-Id: Iccec75cfc0cf16bd717a9bd4606d1e772c332ccc
---
M examples/m3ua_example.c
M include/osmocom/sigtran/sccp_sap.h
M src/sccp_sap.c
3 files changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/examples/m3ua_example.c b/examples/m3ua_example.c
index 6c2b146..b3a1505 100644
--- a/examples/m3ua_example.c
+++ b/examples/m3ua_example.c
@@ -109,7 +109,7 @@
 
 	if (client) {
 		g_sccp = osmo_sccp_simple_client(NULL, "client", 23, OSMO_SS7_ASP_PROT_M3UA, 0, NULL, M3UA_PORT, "127.0.0.2");
-		sccp_test_user_vty_install(g_sccp, OSMO_SCCP_SSN_BSC_BSSAP);
+		sccp_test_user_vty_install(g_sccp, OSMO_SCCP_SSN_BSSAP);
 	} else {
 		g_sccp = sua_server_helper();
 		sccp_test_server_init(g_sccp);
diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h
index 5524bd8..7a4f9bf 100644
--- a/include/osmocom/sigtran/sccp_sap.h
+++ b/include/osmocom/sigtran/sccp_sap.h
@@ -129,10 +129,11 @@
 	OSMO_SCCP_SSN_GGSN_MAP		= 150,
 	/* national network SSN within GSM/UMTS: 32-128 + 151-254 */
 	OSMO_SCCP_SSN_PCAP		= 249,
-	OSMO_SCCP_SSN_BSC_BSSAP		= 250,
-	OSMO_SCCP_SSN_MSC_BSSAP		= 251,
+	OSMO_SCCP_SSN_BSC_BSSAP_LE	= 250,
+	OSMO_SCCP_SSN_MSC_BSSAP_LE	= 251,
 	OSMO_SCCP_SSN_SMLC_BSSAP	= 252,
 	OSMO_SCCP_SSN_BSS_OAM		= 253,
+	OSMO_SCCP_SSN_BSSAP		= 254,
 };
 
 extern const struct value_string osmo_sccp_ssn_names[];
diff --git a/src/sccp_sap.c b/src/sccp_sap.c
index e5addb1..3646685 100644
--- a/src/sccp_sap.c
+++ b/src/sccp_sap.c
@@ -126,9 +126,10 @@
 	{ OSMO_SCCP_SSN_SGSN_MAP,	"SGSN_MAP" },
 	{ OSMO_SCCP_SSN_GGSN_MAP,	"GGSN_MAP" },
 	{ OSMO_SCCP_SSN_PCAP,		"PCAP" },
-	{ OSMO_SCCP_SSN_BSC_BSSAP,	"BSC_BSSAP" },
-	{ OSMO_SCCP_SSN_MSC_BSSAP,	"MSC_BSSAP" },
+	{ OSMO_SCCP_SSN_BSC_BSSAP_LE,	"BSC_BSSAP_LE" },
+	{ OSMO_SCCP_SSN_MSC_BSSAP_LE,	"MSC_BSSAP_LE" },
 	{ OSMO_SCCP_SSN_SMLC_BSSAP,	"SMLC_BSSAP" },
 	{ OSMO_SCCP_SSN_BSS_OAM,	"BSS_OAM" },
+	{ OSMO_SCCP_SSN_BSSAP,		"BSSAP" },
 	{ 0, NULL }
 };

-- 
To view, visit https://gerrit.osmocom.org/3775
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccec75cfc0cf16bd717a9bd4606d1e772c332ccc
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list