[PATCH] osmo-sip-connector[master]: sdp.c Send octet-align in fmtp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Sep 2 17:48:19 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3735

to look at the new patch set (#6).

sdp.c Send octet-align in fmtp

rfc4867 8.2:

      octet-align: Permissible values are 0 and 1.  If 1, octet-aligned
               operation SHALL be used.  If 0 or if not present,
               bandwidth-efficient operation is employed.

We don't have any support for AMR BE mode, but if we don't
send this the other end expects BE mode and can't decode the stream

Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa670055
---
M src/sdp.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/35/3735/6

diff --git a/src/sdp.c b/src/sdp.c
index ccd000d..0245651 100644
--- a/src/sdp.c
+++ b/src/sdp.c
@@ -166,8 +166,13 @@
 char *sdp_create_file(struct sip_call_leg *leg, struct call_leg *other)
 {
 	struct in_addr net = { .s_addr = ntohl(other->ip) };
+	char *fmtp_str = "";
 
 	leg->wanted_codec = app_media_name(other->payload_msg_type);
+
+        if (other->payload_msg_type == GSM_TCH_FRAME_AMR)
+                        fmtp_str = talloc_asprintf(leg,"a=fmtp:%d octet-align=1 mode-set=4\r\n",other->payload_type);
+
 	return talloc_asprintf(leg,
 				"v=0\r\n"
 				"o=Osmocom 0 0 IN IP4 %s\r\n"
@@ -175,9 +180,11 @@
 				"c=IN IP4 %s\r\n"
 				"t=0 0\r\n"
 				"m=audio %d RTP/AVP %d\r\n"
+				"%s"
 				"a=rtpmap:%d %s/8000\r\n",
 				inet_ntoa(net), inet_ntoa(net), /* never use diff. addr! */
 				other->port, other->payload_type,
+				fmtp_str,
 				other->payload_type,
 				leg->wanted_codec);
 }

-- 
To view, visit https://gerrit.osmocom.org/3735
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa670055
Gerrit-PatchSet: 6
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list