libosmocore[master]: Enable GnuTLS fallback

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Oct 31 09:22:06 UTC 2017


Patch Set 2:

I would argue to activate the --enable-gnutls by default, if it is present on the system.  But I don't have a strong opinion here.  Or maybe rather, fail configure.ac if gnutls is not found AND no --disable-gnutls was present.

Furthermore, in terms of efficiency (we allocate TMSIs all the time on a busy network), it makes sense to cache the failure of the syscall and not attempt to use the syscall at every random number generation to then fall back to gnutls.  Let's try once, and if it fails store that in a static variable and use that variable next time.  Does that make sense?

-- 
To view, visit https://gerrit.osmocom.org/4593
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77866ce65acf524b768882c751a4f9c0635740b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


More information about the gerrit-log mailing list