[MERGED] osmo-msc[master]: defaults: assign TMSI by default

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Oct 31 01:03:45 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: defaults: assign TMSI by default
......................................................................


defaults: assign TMSI by default

When using ciphering, the TMSI is an important part of the ciphering. To guard
against users forgetting to set 'assign tmsi' in the config and compromising
their ciphering unknowingly, the default should be to use a TMSI.

To optimize in an unencrypted network, 'no assign tmsi' config can still switch
off TMSI use.

Change-Id: If115e95bebc314bedb50faf3993b52071fee5c1e
---
M src/libvlr/vlr.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index adfe258..07c31ee 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -995,6 +995,9 @@
 	INIT_LLIST_HEAD(&vlr->operations);
 	memcpy(&vlr->ops, ops, sizeof(vlr->ops));
 
+	/* defaults */
+	vlr->cfg.assign_tmsi = true;
+
 	/* osmo_auth_fsm.c */
 	osmo_fsm_register(&vlr_auth_fsm);
 	/* osmo_lu_fsm.c */

-- 
To view, visit https://gerrit.osmocom.org/4556
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If115e95bebc314bedb50faf3993b52071fee5c1e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list