[MERGED] osmo-msc[master]: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Oct 31 01:01:10 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt
......................................................................


msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt

Before this, a code change in libvlr or libmsc would not cause a rebuild of the
tests.

You'd have thought 'AM_LDADD' were the right name for the variable, but
apparently it is just 'LDADD' instead. Tested that it works as intended.

Change-Id: Icbdedc1581fa23abe9ed99cef3918592b25f30b3
---
M tests/msc_vlr/Makefile.am
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/msc_vlr/Makefile.am b/tests/msc_vlr/Makefile.am
index 9af9870..b1bf78e 100644
--- a/tests/msc_vlr/Makefile.am
+++ b/tests/msc_vlr/Makefile.am
@@ -31,6 +31,9 @@
 	-Wl,--wrap=msc_stop_paging \
 	-Wl,--wrap=gsm340_gen_scts \
 	-Wl,--wrap=RAND_bytes \
+	$(NULL)
+
+LDADD = \
 	$(top_builddir)/src/libmsc/libmsc.a \
 	$(top_builddir)/src/libcommon-cs/libcommon-cs.a \
 	$(top_builddir)/src/libvlr/libvlr.a \

-- 
To view, visit https://gerrit.osmocom.org/4551
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icbdedc1581fa23abe9ed99cef3918592b25f30b3
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list