[PATCH] osmo-ci[master]: jobs: fix multiline cmds with less-indented first line comments

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 30 04:04:06 UTC 2017


Review at  https://gerrit.osmocom.org/4584

jobs: fix multiline cmds with less-indented first line comments

Interestingly enough, only a line that has more indenting than the first line
also receives an actual newline in the resulting jenkins Execute Shell section.
Hence insert '# keep first line with less indent' comments.

Change-Id: I13bcb41fa0e59b60a201c2b769bad42067e34ab8
---
M jobs/gerrit-verifications.yml
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/84/4584/1

diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 969b483..cabd5ca 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -51,6 +51,7 @@
           a1: !!python/tuple [arm-none-eabi, amd64]
           combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")'
           cmd: >
+           # keep first line with less indent to preserve newlines
             if [[ "$JOB_NAME" == *"arch=arm-none-eabi,label=linux_amd64_debian8"* ]]; then
               ./contrib/jenkins-arm.sh
             else
@@ -68,9 +69,9 @@
           a3_name: IU
           a3: !!python/tuple [--disable-iu]
           cmd: >
+           # keep first line with less indent to preserve newlines
             ARTIFACT_STORE="$HOME/jenkins_build_artifact_store"
             mkdir -p "$ARTIFACT_STORE"
-
             docker run --rm=true -e HOME=/build -e ARTIFACT_STORE=/artifact_store \
               -e JOB_NAME="$JOB_NAME" -e MAKE=make -e PARALLEL_MAKE="$PARALLEL_MAKE" \
               -e IU="$IU" -e SMPP="$SMPP" -e MGCP="$MGCP" -e PATH="$PATH:/build_bin" \
@@ -127,9 +128,9 @@
           a1_name: IU
           a1: !!python/tuple [--enable-iu, --disable-iu]
           cmd: >
+           # keep first line with less indent to preserve newlines
             ARTIFACT_STORE="$HOME/jenkins_build_artifact_store"
             mkdir -p "$ARTIFACT_STORE"
-
             docker run --rm=true -i -e HOME=/build -e ARTIFACT_STORE=/artifact_store \
               -e JOB_NAME="$JOB_NAME" -e MAKE=make -e PARALLEL_MAKE="$PARALLEL_MAKE" \
               -e IU="$IU" -e PATH="$PATH:/build_bin" -e OSMOPY_DEBUG_TCP_SOCKETS="1" \

-- 
To view, visit https://gerrit.osmocom.org/4584
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13bcb41fa0e59b60a201c2b769bad42067e34ab8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list