osmo-mgw[master]: sdp: refactoring sdp parser/generator

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Oct 29 04:15:15 UTC 2017

Patch Set 14: Code-Review-1


(introducing new comment markings -- '-1:' are the blockers, '?:' aren't important...)

File src/libosmo-mgcp/mgcp_sdp.c:

Line 147: static void codecs_update(void *ctx, struct sdp_rtp_map *codecs, int used,
?: const struct ... codecs

Line 197:  *  \param[out] conn associated rtp connection.
-1: oh, conn is also an output param? if yes, explain what is returned in conn

Line 335:  *  \returns 0 on success, -1 on failure. */
-1: this returns doc is not accurate, you're returning the len. Why though? the msgb is good in keeping its size.

Line 350: 
?: add

  /* FIXME: constify endp and conn args in get_net_donwlink_format_cb() */

and best follow up with a separate patch now.

Line 366: 	len += rc;
?: I guess we can skip counting the len and just return 0 below.....

To view, visit https://gerrit.osmocom.org/4006
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324
Gerrit-PatchSet: 14
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes

More information about the gerrit-log mailing list