osmo-hlr[master]: add osmo-hlr-db-tool, program to migrate from osmo-nitb db

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Oct 29 04:00:41 UTC 2017


Patch Set 2:

(5 comments)

Thanks for hijacking, I guess, but I still found these:

https://gerrit.osmocom.org/#/c/4441/2/src/hlr_db_tool.c
File src/hlr_db_tool.c:

Line 54: 	printf("Usage: osmo-hlr-db-tool [-l <hlr.db>] import-nitb-db <nitb.db>]\n");
one opening '[' missing; or a ']' too many, depending.


Line 55: 	printf("Call without arguments to create a new empty ./hlr.db.\n");
^ This is no longer accurate.


Line 138: 		exit(EXIT_FAILURE);
would re-enable implicit bootstrap by 'return' here, instead of exit()


Line 142: 	printf("command '%s', %d extra arguments\n", cmd, argc - optind);
debug leftover?


Line 390: 	/* Future: add more main_actions, besides --import-nitb-db, here. */
(drop '--')


-- 
To view, visit https://gerrit.osmocom.org/4441
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dfa6ec033dd93161c1adc2ce1637195fe5b7a63
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list