This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: fix compiler warning: drop dead code from BIT_STRING_fromBuf() ...................................................................... fix compiler warning: drop dead code from BIT_STRING_fromBuf() The warning is, on FreeBSD, CC asn1helpers.lo asn1helpers.c:68:10: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] if (len < 0) ~~~ ^ ~ Change-Id: I80867da697d744d7ef4d70c8f24031f5781fb11a --- M src/asn1helpers.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/asn1helpers.c b/src/asn1helpers.c index a4ced70..4e5e08d 100644 --- a/src/asn1helpers.c +++ b/src/asn1helpers.c @@ -65,9 +65,6 @@ return 0; } - if (len < 0) - len = strlen((char*)str); - buf = MALLOC(len); if (!buf) { errno = ENOMEM; -- To view, visit https://gerrit.osmocom.org/4492 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80867da697d744d7ef4d70c8f24031f5781fb11a Gerrit-PatchSet: 2 Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder