osmo-pcu[master]: Initialize logging before initializing rate_ctr

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Oct 28 03:04:23 UTC 2017


Patch Set 9:

> > why the extensive move / separate files are needed
 > 
 > There's a ticket about getting rid of BTS singleton

Getting rid of the singleton sounds good to me, but this patch doesn't seem to do that at all...

I guess having one global counters pointer and not making it a BTS member makes most sense to me, and then the move to pcu_ctr.c also makes sense.

-- 
To view, visit https://gerrit.osmocom.org/4411
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf557d21552d9ff1d6b595b0594f2c7b18db4692
Gerrit-PatchSet: 9
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list