This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 8: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/4413/8/src/bts.cpp File src/bts.cpp: Line 165: rlc_late_block(bts_data()->ctrs); I'm sorry, I really think it's ugly to pass around a counter array to various functions that don't take any other argument. Either the counters can be resolved from some larger struct/object of which the counters are a member, but which makes actual sense to the related function, or the respective function like rlc_late_block() would have to be a method of an object which has access to the counters? -- To view, visit https://gerrit.osmocom.org/4413 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I795631752af3b9077a846c3123217e1deda52e86 Gerrit-PatchSet: 8 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes