osmo-hlr[master]: ctrl: completely replace all CTRL commands

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Oct 24 14:50:34 UTC 2017


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/#/c/4311/5/src/ctrl.c
File src/ctrl.c:

Line 98: 		cmd->reply = NULL;
> Maybe it's better to return smth like "unknown/unexpected error"? It would 
the ctrl API will insert a generic error message for us, no need to invent a new one.

... but now that I look at it in control_if.c:300, it actually also logs a notice that something failed to set an error message, so after all you're right.


Line 389: 					  _LAST_CTRL_NODE_HLR);
> So we not only replace the commands, we also change the way we setup and us
It is required to use ..._dynip2(), otherwise I would have to add the HLR CTRL_NODE enum values in libosmocore. You have a point about hlr_controlif_setup arguments changing though; and I have an unnecessary cosmetic change, too.


https://gerrit.osmocom.org/#/c/4311/5/src/ctrl.h
File src/ctrl.h:

Line 30: 	_LAST_CTRL_NODE_HLR
> Same as ctrl.c - shouldn't this belong to a separate patch? This have nothi
no, this one belongs in this patch, I am using these new nodes to provide the new ctrl commands.


-- 
To view, visit https://gerrit.osmocom.org/4311
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
Gerrit-PatchSet: 5
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list