libosmocore[master]: GPRS: check and report local address used for NSE

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Oct 24 14:44:56 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/4395/2/src/gb/gprs_ns_vty.c
File src/gb/gprs_ns_vty.c:

Line 168: 		int rc = osmo_sock_local_ip((char *)&local, inet_ntoa(nsvc->ip.bts_addr.sin_addr));
Why that cast?

either just type local or &local[0]?


-- 
To view, visit https://gerrit.osmocom.org/4395
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6932a29c7899d36bcc275f05dda9670b0e69bef0
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list