libosmocore[master]: Add tests for bitvec_write_field()

Max gerrit-no-reply at lists.osmocom.org
Mon Oct 23 15:22:46 UTC 2017


Patch Set 3:

> certainly nicer to not test a duplicate that may go out of sync

We do not test "duplicate" we test bitvec_write_field() so it does not matter if code in the test differs from code in OsmoPCU (it probably already is). As long as bitvec_write_field() works as expected, the code in OsmoPCU will continue to work.

-- 
To view, visit https://gerrit.osmocom.org/4336
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee544256b8675bc62a42493aab66a8eeee54f90
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list