libosmocore[master]: gb: optionally allow nsip packets only from a specific host

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 15:00:32 UTC 2017


Patch Set 2:

one step back from the release process discussion, which we should probably have been doing on openbsc@ anyway, back to this patch:

The only API/ABI break here is adding struct members, and that is only a breaking change because we have a nested struct. What would it take to make this commit *not* break compatibility in the first place?

  struct gprs_ns_inst {
  [...]
  	/*! NS-over-IP specific bits */
  	struct {
  		struct osmo_fd fd;
  		uint32_t local_ip;
  		uint16_t local_port;
  		int dscp;
  +               /* see also .nsip2 */
  	} nsip;
  	/*! NS-over-FR-over-GRE-over-IP specific bits */
  	struct {
  		struct osmo_fd fd;
  		uint32_t local_ip;
  		unsigned int enabled:1;
  	} frgre;
  +
  +	struct {
  +		uint32_t remote_ip;
  +		uint16_t remote_port;
  +	} nsip2;
  };

Kind of similar to adding new signature to existing API functions. The end result is not particularly beautiful, but we'd not break API.

-- 
To view, visit https://gerrit.osmocom.org/4317
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb201d9006eec275a46708007ff342cdfc14e45
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list