osmo-mgw[master]: mgcp: move port/timeslot calculator to mgcp_common.h

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 14:39:24 UTC 2017


Patch Set 6: Code-Review-2

> I have to be able to call the functions here: https://gerrit.osmocom.org/#/c/4334/4/src/osmo-bsc/osmo_bsc_bssap.c
 > (caller is bssmap_handle_clear_command())

Nope, the caller is bssmap_handle_assignm_req(). Right?

Let's take a look at the general situation. If I'm not missing anything, your only caller is inside an 'if' path that is for SCCPlite, and we are also discussing whether having SCCPlite paths in the new osmo-bsc is even possible. If the AoIP osmo-bsc can do SCCPlite, it should be by adding SCCPlite to libosmo-sigtran, according to Harald. IIUC your changes to include AoIP in osmo-bsc have disconnected SCCPlite beyond a working state, so it makes no sense to move things into libosmo-mgcp just to accomodate legacy code that we should drop instead. Let me know if I'm missing anything here.

All other callers are in osmo-bsc_nat, which still needs a separate close look. I still don't know / keep forgetting what its precise use is and, more importantly, how it relates to our new libosmo-mgcp and -client. Maybe it should just remain using libosmo-legacy-mgcp for the time being?

Any "weird" port calculation functions should then go directly to the program using them or remain in libosmo-legacy-mgcp.

Marking -2 for now until these questions are resolved.

-- 
To view, visit https://gerrit.osmocom.org/4237
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a553e863701d3bafa7b8dc17a503455c303546e
Gerrit-PatchSet: 6
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list