[MERGED] osmo-hlr[master]: fix mem leak in handle_cmd_ps(): free luop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 12:20:50 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix mem leak in handle_cmd_ps(): free luop
......................................................................


fix mem leak in handle_cmd_ps(): free luop

Each GSUP client creates a luop, but since lu_op_tx_del_subscr_data() doesn't
free the luop, each allocated luop leaks memory.

Change-Id: If912dc992bc7f18c49d22ec0436d9679c1cd04f6
---
M src/ctrl.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ctrl.c b/src/ctrl.c
index 8682e14..74172c4 100644
--- a/src/ctrl.c
+++ b/src/ctrl.c
@@ -54,6 +54,7 @@
 			luop = lu_op_alloc_conn(co);
 			lu_op_fill_subscr(luop, ctx->dbc, cmd->value);
 			lu_op_tx_del_subscr_data(luop);
+			lu_op_free(luop);
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/4308
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If912dc992bc7f18c49d22ec0436d9679c1cd04f6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list