osmo-sgsn[master]: ifdef: fix conditional compiling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Oct 23 01:40:45 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/4369/1//COMMIT_MSG
Commit Message:

Line 7: ifdef: fix conditional compiling
I find the summary too general. Which conditional? what parts of the code?


https://gerrit.osmocom.org/#/c/4369/1/src/gprs/gtphub_main.c
File src/gprs/gtphub_main.c:

Line 122: #endif
I'm in two minds what to say now :)

In the old VTY code, this would not do. We would have to change the node like osmo_ss7_vty_go_parent() does in its 'default:' case.

Since the VTY indenting patch is merged, this will actually work, since the internal vty-go-parent semantics pop a node element from the stack instead of relying on the go_parent cb.

Actually the best solution would be to not even register a go_parent_cb in the first place in case of !BUILD_IU


-- 
To view, visit https://gerrit.osmocom.org/4369
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c609ef0c344ce825c313335c7e084bf97159262
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list