This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 7: Code-Review+1 (2 comments) +2 as soon as the whitespace change is in the patch that introduced the error https://gerrit.osmocom.org/#/c/4227/7/include/osmocom/mgcp_client/mgcp_client.h File include/osmocom/mgcp_client/mgcp_client.h: Line 39: char audio_ip[INET_ADDRSTRLEN]; so this patch fixes an indenting error from the other one? Rather move that over to the other patch. https://gerrit.osmocom.org/#/c/4227/7/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: Line 913: * RFC3435 Section F.7) */ wow, was it really designed like this? :) let's hope we always have nonempty connection IDs then. -- To view, visit https://gerrit.osmocom.org/4227 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fcc72775bf72b489ff79ade36fb345d8d20736 Gerrit-PatchSet: 7 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes