libosmocore[master]: GPRS: log NS socket

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Oct 20 18:17:19 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4370/1/src/gb/gprs_ns.c
File src/gb/gprs_ns.c:

Line 1583: 	LOGP(DLGLOBAL, LOGL_NOTICE, "NS UDP socket at %s:%d\n", inet_ntoa(in), nsi->nsip.local_port);
The log subsystem is somewhat questionable here.  It still is a NS related message.  We currently only use that whenever we do not have a specific logging sub-system for the code, like e.g. in the generic socket helper, or in the logging code.  I would hence make this "DNS" instead of DLGLOBAL"


-- 
To view, visit https://gerrit.osmocom.org/4370
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9d0f94ab2c1bb33f67cd4f1c9236b64108c0bb6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list